doohoyi/comport
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

negative port-numbers at creation time indicate not-to-open

Browse source 
Closes: https://git.iem.at/pd/comport/-/issues/5
This commit is contained in:
IOhannes m zmölnig 2024-09-26 16:48:32 +02:00
parent 53f49d7004
commit b66214e6a8
1 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
comport.c
View file

@ -1364,7 +1364,7 @@ static void *comport_new(t_symbol *s, int argc, t_atom *argv)
t_comport *x; t_comport *x;
HANDLE fd; HANDLE fd;
const char *serial_device_prefix; const char *serial_device_prefix;
t_float com_num = 0; int com_num = 0;
int ibaud = 9600; int ibaud = 9600;
(void)s; /* squelch unused-parameter warning */ (void)s; /* squelch unused-parameter warning */
@ -1389,7 +1389,7 @@ allows COM port numbers to be specified. */
if(argc > 0) { if(argc > 0) {
if (argv->a_type == A_FLOAT) if (argv->a_type == A_FLOAT)
com_num = atom_getfloatarg(0, argc, argv); com_num = (int)atom_getfloatarg(0, argc, argv);
else else
serial_device_prefix = atom_getsymbol(argv)->s_name; serial_device_prefix = atom_getsymbol(argv)->s_name;
} }
@ -1414,7 +1414,13 @@ allows COM port numbers to be specified. */
test.ctsrts = 0; /* default no hardware handshaking */ test.ctsrts = 0; /* default no hardware handshaking */
test.xonxoff = 0; /* default no software handshaking */ test.xonxoff = 0; /* default no software handshaking */
test.hupcl = 1; /* default hangup on close */ test.hupcl = 1; /* default hangup on close */
/* don't try to open negative devices */
if(com_num < 0) {
fd = INVALID_HANDLE_VALUE;
} else {
fd = open_serial((unsigned int)com_num, &test); fd = open_serial((unsigned int)com_num, &test);
}
/* Now nothing really bad could happen so we create the class */ /* Now nothing really bad could happen so we create the class */
x = (t_comport *)pd_new(comport_class); x = (t_comport *)pd_new(comport_class);
@ -1436,9 +1442,9 @@ allows COM port numbers to be specified. */
x->hupcl = test.hupcl; x->hupcl = test.hupcl;
x->comhandle = fd; /* holds the comport handle */ x->comhandle = fd; /* holds the comport handle */
if(fd == INVALID_HANDLE_VALUE ) if(fd == INVALID_HANDLE_VALUE && com_num>=0)
{ {
pd_error(x, "[comport] opening serial port %g failed!", com_num); pd_error(x, "[comport] opening serial port %d failed!", com_num);
} }
else else
{ {